drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 34184: DRILL-3065: Memory Leak at ExternalSortBatch
Date Thu, 14 May 2015 22:46:07 GMT


> On May 14, 2015, 10:40 p.m., abdelhakim deneche wrote:
> > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java,
line 803
> > <https://reviews.apache.org/r/34184/diff/2/?file=960663#file960663line803>
> >
> >     Should this test be part of TestDrillbitResilience ?
> 
> Sean Hsuan-Yi Chu wrote:
>     It is just a utility function helping write the test cases.

my bad, actually thought it was a unit test.


- abdelhakim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34184/#review83858
-----------------------------------------------------------


On May 14, 2015, 9:59 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34184/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 9:59 p.m.)
> 
> 
> Review request for drill, abdelhakim deneche, Jinfeng Ni, and Steven Phillips.
> 
> 
> Bugs: DRILL-3065
>     https://issues.apache.org/jira/browse/DRILL-3065
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Clean the SelectionVector4 in mSort after failure happens
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
529a6ca 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java
9acae9e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSorter.java
d97ffc0 
>   exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
f95fbe1 
> 
> Diff: https://reviews.apache.org/r/34184/diff/
> 
> 
> Testing
> -------
> 
> Unit test passed; Others are running
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message