drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Review Request 34188: DRILL-3074: ReconnectingClient.waitAndRun can stuck in infinite loop if it fails to establish the connection
Date Thu, 14 May 2015 02:10:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34188/
-----------------------------------------------------------

Review request for drill, Jacques Nadeau and Steven Phillips.


Repository: drill-git


Description
-------

Main issue is if we fail in connecting or timeout, we go into an infinite loop.

1. Fix infinite loop issue in ReconnectingClient.waitAndRun
2. Make timeout to 120second
3. Change the ReconnectingConnection and BasicClient to wait for at most 120secs


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClient.java 34758ef 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ReconnectingConnection.java 12e0063


Diff: https://reviews.apache.org/r/34188/diff/


Testing
-------


Thanks,

Venki Korukanti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message