drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 34173: DRILL-3053: add unchecked exception injection site in ChildAllocator
Date Wed, 13 May 2015 22:05:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34173/
-----------------------------------------------------------

(Updated May 13, 2015, 10:05 p.m.)


Review request for drill, Chris Westin and Jacques Nadeau.


Changes
-------

small code fixes


Bugs: DRILL-3053
    https://issues.apache.org/jira/browse/DRILL-3053


Repository: drill-git


Description
-------

added an unchecked injection site in ChildAllocator.buffer(int, int). It's only enabled when
assertions are enabled.
You can throw any unchecked or Error exception, but if you throw a NullPointerException the
buffer() method will just return "null" without throwing any exception to simulate a "normal"
allocation failure


Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/exceptions/DrillRuntimeException.java abc7065

  common/src/main/java/org/apache/drill/common/exceptions/UserException.java a67cb3f 
  exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java 9670c7e

  exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControlsInjector.java
387d300 
  exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java PRE-CREATION


Diff: https://reviews.apache.org/r/34173/diff/


Testing (updated)
-------

testing...


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message