drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 34071: DRILL-3034: Apply UserException to port-binding; handle in embedded-Drill case.
Date Tue, 12 May 2015 18:36:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34071/#review83446
-----------------------------------------------------------


+1 (non binding)

- abdelhakim deneche


On May 12, 2015, 5:49 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34071/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 5:49 p.m.)
> 
> 
> Review request for drill, abdelhakim deneche, Mehant Baid, and Parth Chandra.
> 
> 
> Bugs: DRILL-3034
>     https://issues.apache.org/jira/browse/DRILL-3034
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Applied UserException to can't-bind-to-port error.  [BasicServer]
> Added specific handling of UserException (above case or other) in SQLException wrapping.
 [DrillConnectionImpl]
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java a148436 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 30279e6 
> 
> Diff: https://reviews.apache.org/r/34071/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in SQLLine and debugger.
> 
> Ran regular tests; no new failures.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message