drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau" <jacques.dr...@gmail.com>
Subject Re: Review Request 34008: DRILL:2977: In WorkManager, startFragmentPendingRemote() and addFragmentRunner() need to be permuted
Date Tue, 12 May 2015 03:24:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34008/#review83346
-----------------------------------------------------------

Ship it!


Ship It!

- Jacques Nadeau


On May 12, 2015, 12:32 a.m., Sudheesh Katkam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34008/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 12:32 a.m.)
> 
> 
> Review request for drill, abdelhakim deneche, Jacques Nadeau, and Venki Korukanti.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> [DRILL-2977](https://issues.apache.org/jira/browse/DRILL-2977), [DRILL-2978](https://issues.apache.org/jira/browse/DRILL-2978):
Swap fragment execution methods and cancellation changes
> 
> Execution: In WorkManager,
> + swap implementations of startFragmentPendingRemote() and addFragmentRunner()
> + warn if there are running fragments in close()
> 
> Cancellation:
> + for fragments waiting on data, delegate cancellations to WorkEventBus (in Foreman and
ControlMessageHandler)
> + documentation
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java d90096a

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java 1d3a0b0 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java
d12e6d5 
>   exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 090a377

>   exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java
67ef9b8 
> 
> Diff: https://reviews.apache.org/r/34008/diff/
> 
> 
> Testing
> -------
> 
> Passes all unit tests and regression tests.
> 
> 
> Thanks,
> 
> Sudheesh Katkam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message