drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 34028: DRILL-3020: Copy cause exception's message to thrown SQLException's message.
Date Mon, 11 May 2015 18:06:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34028/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-3020
    https://issues.apache.org/jira/browse/DRILL-3020


Repository: drill-git


Description
-------

Changed SQLException construction to set SQLException's message to the cause exception's toString().
    
Also:
- Narrowed one SQLException to SQLNonTransientConnectionException (not other
  two, since unclear whether transient, non-transient, or varied).
- Clarified/simplified exception messages.
- Fixed message typo.


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 30279e6 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 30c85eb 

Diff: https://reviews.apache.org/r/34028/diff/


Testing
-------

Manually tested in SQLLine.

Ran regular tests; no new failures.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message