drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Westin" <chriswesti...@gmail.com>
Subject Re: Review Request 34030: DRILL-3022: ensure sequential shutdown of drillbits
Date Mon, 11 May 2015 06:40:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34030/#review83203
-----------------------------------------------------------


With the addition of a comment explaining what's going on here, ship it (non-binding).


exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java
<https://reviews.apache.org/r/34030/#comment134106>

    I also added this block comment before the synchronized block in my version:
    
            /*
             * We can avoid metrics deregistration concurrency issues by only closing
             * one drillbit at a time. To enforce that, we synchronize on a convenient
             * singleton object.
             */


- Chris Westin


On May 10, 2015, 11:37 p.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34030/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 11:37 p.m.)
> 
> 
> Review request for drill, Chris Westin and Venki Korukanti.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3022: ensure sequential shutdown of drillbits
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 531253e4245a1a4f50216359ed5591f0f1804b31

> 
> Diff: https://reviews.apache.org/r/34030/diff/
> 
> 
> Testing
> -------
> 
> unit
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message