drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 34026: DRILL-2993: Unthrottle at cancel() to fix post-cancelation hangs.
Date Sun, 10 May 2015 22:29:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34026/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-2993
    https://issues.apache.org/jira/browse/DRILL-2993


Repository: drill-git


Description
-------

Added unthrottling in close().
Cleaned up throttling logic code:
- Applied AtomicBoolean to eliminate race conditions.
- Extracted methods for starting/stopping throttling.
    
Made small edits to some message:
- Fixed missed, inconsistent ResultsListener log messages.
- Clarified exception message.


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java 8ef2af3 

Diff: https://reviews.apache.org/r/34026/diff/


Testing
-------

Manually confirmed unthrottling upon cancelation and delivery of messages (via log message)
and confirmed lack of previous hanging behavior on subsequence queries.

Ran regular tests; no new errors.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message