drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudheesh Katkam" <skat...@maprtech.com>
Subject Re: Review Request 33770: DRILL-2697 Pause injections should pause indefinitely until signalled
Date Sat, 09 May 2015 17:48:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33770/
-----------------------------------------------------------

(Updated May 9, 2015, 5:48 p.m.)


Review request for drill, Chris Westin, Jacques Nadeau, and Venki Korukanti.


Changes
-------

Rebase on master (resolved merge conflicts)


Repository: drill-git


Description
-------

[DRILL-2697](https://issues.apache.org/jira/browse/DRILL-2697): Pauses sites wait indefinitely
for a resume signal
DrillClient sends a resume signal to UserServer. UserServer triggers a resume call in the
correct Foreman. Foreman resumes all pauses related to the query through the Control layer.

+ Better error messages and more tests in TestDrillbitResilience and TestPauseInjection
+ Added execution controls to operator context
+ Removed ControlMessageHandler interface, renamed ControlHandlerImpl to ControlMessageHandler
+ Added CountDownLatchInjection, useful in cases like ParititionedSender that spawns multiple
threads


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 136d8c7 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContext.java 7cc52ba 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java 6dbd880

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java 5b4d7bd

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlRpcConfig.java f92bb49

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlTunnel.java a4f9fdf

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserRpcConfig.java ae728d8 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java b3b7ae9 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoRecordReader.java cf98b83

  exec/java-exec/src/main/java/org/apache/drill/exec/testing/CountDownLatchInjection.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/testing/CountDownLatchInjectionImpl.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControls.java 1171bf8

  exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControlsInjector.java
4b1cd0c 
  exec/java-exec/src/main/java/org/apache/drill/exec/testing/Injection.java 96fed3a 
  exec/java-exec/src/main/java/org/apache/drill/exec/testing/NoOpControlsInjector.java 80d9790

  exec/java-exec/src/main/java/org/apache/drill/exec/testing/PauseInjection.java e5f9c9c 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java a3ceb8f 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlHandlerImpl.java b6c6852

  exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java
c5d78cc 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java b7ef584 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 34fa639

  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java ddb828c

  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentManager.java 0ba91b4

  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/NonRootFragmentManager.java
f526fbe 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java
b1c3fe0 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/user/UserWorker.java 8854ef3 
  exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java da69e9e

  exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestCountDownLatchInjection.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java 5fa2b3f

  protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java 470e976 
  protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java c3ff58b 
  protocol/src/main/java/org/apache/drill/exec/proto/beans/RpcType.java 4d03073 
  protocol/src/main/protobuf/BitControl.proto 93bc33c 
  protocol/src/main/protobuf/User.proto 185a646 

Diff: https://reviews.apache.org/r/33770/diff/


Testing
-------

Passes all unit tests.


Thanks,

Sudheesh Katkam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message