drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Re: Review Request 33897: DRILL-2602: Throw an error on schema change during streaming aggregation
Date Thu, 07 May 2015 17:37:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33897/#review82847
-----------------------------------------------------------

Ship it!


Ship It!

- Jason Altekruse


On May 7, 2015, 11:44 a.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33897/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 11:44 a.m.)
> 
> 
> Review request for drill and Jason Altekruse.
> 
> 
> Bugs: DRILL-2602
>     https://issues.apache.org/jira/browse/DRILL-2602
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> updated both ExternalSortBatch and StreamAggBatch to throw a proper UNSUPPORTED user
exception.
> Here is the output when using a Stream aggregate:
> ```
> Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support sorts with
changing schemas
> 
> Fragment 0:0
> 
> [Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010]
> ```
> And here is the error message for a hash aggregate:
> ```
> Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support schema changes
> 
> Fragment 0:0
> 
> [Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010]
> ```
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
b753574 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
e88bc67 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java
75892f9 
> 
> Diff: https://reviews.apache.org/r/33897/diff/
> 
> 
> Testing
> -------
> 
> all unit tests are passing along with customer/tpch100
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message