drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 33893: DRILL-2959: Ensure release and management of compression codecs.
Date Wed, 06 May 2015 18:33:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33893/#review82685
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/DirectCodecFactory.java
<https://reviews.apache.org/r/33893/#comment133472>

    what is the purpose of allocatedBuffers ? it looks like we are storing buffer references
in it's key set, but we never actually use them.



exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/DirectCodecFactory.java
<https://reviews.apache.org/r/33893/#comment133473>

    remove this comment ?



exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/DirectCodecFactory.java
<https://reviews.apache.org/r/33893/#comment133474>

    same



exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/DirectCodecFactory.java
<https://reviews.apache.org/r/33893/#comment133475>

    is this class needed anymore ?



exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetDirectByteBufferAllocator.java
<https://reviews.apache.org/r/33893/#comment133471>

    current implementations of Allocator will return null if it can't allocate the byte buffer.
This will cause a NullPointerException in the next line.
    We should check if bb is null and throw an OutOfMemoryRuntimeException instead


- abdelhakim deneche


On May 6, 2015, 1:22 p.m., Jacques Nadeau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33893/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 1:22 p.m.)
> 
> 
> Review request for drill, abdelhakim deneche and Steven Phillips.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Create a DirectCodecFactory and DirectCodecPool which consolidate our compression tools
use.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/DirectCodecFactory.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/DirectCodecPool.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetDirectByteBufferAllocator.java
45a1dc6 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
cfa4c93 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
3506ffa 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
d5586ce 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
6a41a04 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
11d0042 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
921d134 
>   exec/java-exec/src/main/java/parquet/hadoop/CodecFactoryExposer.java 5438660 
>   exec/java-exec/src/main/java/parquet/hadoop/ColumnChunkIncReadStore.java 242cd28 
>   exec/java-exec/src/main/java/parquet/hadoop/ColumnChunkPageWriteStoreExposer.java 0e9dec0

>   exec/java-exec/src/test/java/org/apache/drill/exec/store/TestDirectCodecFactory.java
PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java
e50e3fb 
>   pom.xml f0f4bc5 
> 
> Diff: https://reviews.apache.org/r/33893/diff/
> 
> 
> Testing
> -------
> 
> regression/unit in progress.
> 
> 
> Thanks,
> 
> Jacques Nadeau
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message