drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Re: Review Request 33834: DRILL-2848: Part 1: ParquetToDrillTypeConverter hygiene patch
Date Wed, 06 May 2015 17:36:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33834/#review82697
-----------------------------------------------------------

Ship it!


Ship It!

- Jason Altekruse


On May 5, 2015, 1:14 a.m., Mehant Baid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33834/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 1:14 a.m.)
> 
> 
> Review request for drill and Jason Altekruse.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> This patch simply cleans up redundant logic in ParquetToDrillTypeConverter and refactors
common logic to determine minor type in a function.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/drill/common/util/CoreDecimalUtility.java 302652e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetToDrillTypeConverter.java
7c3eeb8 
> 
> Diff: https://reviews.apache.org/r/33834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehant Baid
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message