drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 33840: DRILL-2423: Show proper message when trying to drop an unknown view.
Date Tue, 05 May 2015 23:31:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33840/
-----------------------------------------------------------

(Updated May 5, 2015, 11:31 p.m.)


Review request for drill and Jinfeng Ni.


Changes
-------

Addressed review comments. Also added testcase for new code path.


Repository: drill-git


Description
-------

Please see https://issues.apache.org/jira/browse/DRILL-2423 for details.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
2428b45 
  exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestBaseViewSupport.java bfe113b

  exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 2ae6991 

Diff: https://reviews.apache.org/r/33840/diff/


Testing
-------

Added unittests


Thanks,

Venki Korukanti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message