drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 33779: DRILL-2932: Fix: Error text reported via System.out.println rather than thrown SQLException's message
Date Tue, 05 May 2015 03:08:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33779/
-----------------------------------------------------------

(Updated May 5, 2015, 3:08 a.m.)


Review request for drill, abdelhakim deneche, Mehant Baid, and Parth Chandra.


Changes
-------

Addressed comments/discussion:  Added try/finally to free batch; added description to JIRA
report; moved SchemaChangeException handling to with other catches.


Summary (updated)
-----------------

DRILL-2932: Fix: Error text reported via System.out.println rather than thrown SQLException's
message


Bugs: DRILL-2932
    https://issues.apache.org/jira/browse/DRILL-2932


Repository: drill-git


Description (updated)
-------

DRILL-2932: Fix:  Error reported via System.out rather than exception message
    
Main:
- Removed the System.out.println(...) from submissionFailed(...).
- Put UserException's message text in SQLException's message (didn't just wrap).
- Added undoing of extra wrapping by AvaticaStatement.execute...(...).
- Created unit test for execute...(...) exceptions.
- Refined related exception handling (handled cases separately, narrowed throws declarations
and catches).
    
JDBC cleanup:
- Renamed ex -> executionFailureException
- Added getNext() method doc. comment.
- Removed some obsolete alignment spaces.
    
Added "review this" TODOs re DRILL-2933 (probably-obsolete SchemaChangeException):
- DrillCursor;
- MergingRecordBatch, ParquetResultListener, PrintingResultsListener, QueryWrapper, RecordBatchLoader,
UnorderedReceiverBatch;
- TestDrillbitResilience, TestTextColumn, BaseTestQuery, DrillTestWrapper.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/client/PrintingResultsListener.java 64e7266

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
c36b0d3 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
09cb7ad 
  exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java 088630c

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 3beae89

  exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java aa43aa9

  exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java d6e6d08 
  exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java d05c896 
  exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java 2698701

  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java
0e80f91 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestTextColumn.java 3c1a38a

  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 41b89ce 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java ba265e6 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java 484a5e5 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestExecutionExceptionsToClient.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/33779/diff/


Testing
-------

Ran SQLLine to confirm change from System.out plus poor SQLException to good SQLException.

Ran new specific unit test.

Ran regular tests; no new failures.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message