drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid" <baid.meh...@gmail.com>
Subject Review Request 33833: DRILL-2848: Part 2: Provide option to disable decimal type
Date Tue, 05 May 2015 01:11:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33833/
-----------------------------------------------------------

Review request for drill, Jason Altekruse and Jinfeng Ni.


Repository: drill-git


Description
-------

This patch adds an option to enable/ disable decimal data type. Disabled casting to decimal,
reading decimal from parquet and hive.


Diffs
-----

  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBasePushFilterIntoScan.java
f1f3a0b 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java
8c400ea 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoPushDownFilterForScan.java
4fd80bd 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java
92e5678 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java 441f2e3

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillParseContext.java
be4474f 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
c8be019 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java b631cdc

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FlattenPrel.java e206951

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
8f089c4 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectAllowDupPrel.java
cc215f8 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrel.java 35fa5be

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java c918723

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ExplainHandler.java
1636a25 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
33b2a4c 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaPushFilterIntoRecordGenerator.java
0cf12b4 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
11d0042 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetToDrillTypeConverter.java
7c3eeb8 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java
389c1f6 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
921d134 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetRecordMaterializer.java
574df40 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/ExecErrorConstants.java PRE-CREATION

  exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java c627ff2 
  exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java 504524d 
  exec/java-exec/src/test/java/org/apache/drill/TestFrameworkTest.java 3abd193 
  exec/java-exec/src/test/java/org/apache/drill/TestFunctionsQuery.java 67131c1 
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastEmptyStrings.java 3e05c0e

  exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/TestConstantFolding.java 2c23df4

  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
5670e1e 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestWriter.java
5991046 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/columnreaders/TestColumnReaderFactory.java
9ae6b78 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet2/TestDrillParquetReader.java
782191f 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 5c0a0e5 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java aa68e9f


Diff: https://reviews.apache.org/r/33833/diff/


Testing
-------

Added negative tests. 

Modified existing unit tests to use the newly added parameter.


Thanks,

Mehant Baid


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message