Return-Path: 
 <dev-return-12049-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CEF39177A9
	for <apmail-drill-dev-archive@www.apache.org>;
 Sat,  4 Apr 2015 17:11:33 +0000 (UTC)
Received: (qmail 66229 invoked by uid 500); 4 Apr 2015 17:11:33 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 66173 invoked by uid 500); 4 Apr 2015 17:11:33 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 66121 invoked by uid 99); 4 Apr 2015 17:11:33 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Apr 2015 17:11:33 +0000
Date: Sat, 4 Apr 2015 17:11:33 +0000 (UTC)
From: "Deneche A. Hakim (JIRA)" <jira@apache.org>
To: dev@drill.apache.org
Message-ID: <JIRA.12788292.1428167411000.2965.1428167493508@Atlassian.JIRA>
In-Reply-To: <JIRA.12788292.1428167411000@Atlassian.JIRA>
References: <JIRA.12788292.1428167411000@Atlassian.JIRA>
 <JIRA.12788292.1428167411902@arcas>
Subject: [jira] [Created] (DRILL-2692) Do not log errors more than once
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Deneche A. Hakim created DRILL-2692:
---------------------------------------

             Summary: Do not log errors more than once
                 Key: DRILL-2692
                 URL: https://issues.apache.org/jira/browse/DRILL-2692
             Project: Apache Drill
          Issue Type: Improvement
    Affects Versions: 0.8.0
            Reporter: Deneche A. Hakim
            Assignee: Deneche A. Hakim
            Priority: Minor
             Fix For: 0.9.0


When a failure occurs in the execution stack it will be logged up to 6 times in the server logs.

For example trying to query a bad json (extra ':') file will cause the following events:

- ScanBatch.next() logs a debug message "Failed to read the batch. Stopping..." and calls FragmentContext.fail()
- FragmentContext.fail() logs an error message "Fragment Context received failure -- Fragment: "
- FragmentExecutor.run() calls internalFail() and logs an error message when calling ErrorHelper.logAndConvertError()
  "Error <error id>: <error message>"
- Foreman.close() calls ErrorHelper.logAndConvertError() which logs an error message "Error <error id>: <error message>"
- FragmentExecutor.closeOutResources() will throw a RuntimeException because it contains a non null deferredException (the original exception). This exception is caught in run() and a warning message is logged "Error while initializing or executing fragment"
- FragmentExecutor.run() calls FragmentContext.fail() when it catches the RuntimeException which will log an error message "Fragment Context received failure -- Fragment: "



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)