Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAKa9qD=waiejb19R6rNig2v4AC4iqmop1bFdyiR-EwozUoBffQ@mail.gmail.com>
References: 
 <CAKa9qDkwZqHzowLa1gRP+XC=ABQe0329Z5wr+Z_z-ADVeW4XCw@mail.gmail.com>
	<CAFyDVvKWu5nFT3_UUWMFHUV7gZeAtySXsrVk2wUM7=AsZ9E4Rw@mail.gmail.com>
	<CAKa9qD=waiejb19R6rNig2v4AC4iqmop1bFdyiR-EwozUoBffQ@mail.gmail.com>
Date: Thu, 23 Apr 2015 15:56:18 -0700
Message-ID: 
 <CAK55V=JGvDe7kGpyMv7yKC7mmJd8iRFz7qz38vzKUP2_mGjTPg@mail.gmail.com>
Subject: Re: Should we make dir* columns only exist when requested?
From: Jinfeng Ni <jni@apache.org>
To: dev@drill.apache.org
Content-Type: multipart/alternative; boundary=14dae9cc94960ca21405146c3008

--14dae9cc94960ca21405146c3008
Content-Type: text/plain; charset=UTF-8

I think the new proposal makes sense. It makes the behavior of select *
consistent, only returning the regular columns in the table, regardless how
the table/file is specified in the query.

On Thu, Apr 23, 2015 at 2:56 PM, Jacques Nadeau <jacques@apache.org> wrote:

> I'm specifically arguing that SELECT * doesn't return the columns.
>
> Here is current behavior:
>
> /mytdir/mysdir/myfile.json
> {a:1,b:2,c:3}
> {a:4,b:5,c:6}
>
> select * from `myfile.json`
>
> a, b, c
> 1, 2, 3
> 4, 5, 6
>
> select * from `/mysdir/myfile.json`
>
> dir0 a, b, c
> mysdir, 1, 2, 3
> mysdir, 4, 5, 6
>
> select * from `/mytdir/mysdir/myfile.json`
>
> dir0, dir1 a, b, c
> mytdir, mysdir, 1, 2, 3
> mytdir, mysdir, 4, 5, 6
>
>
> ====================================
> My proposal:
>
> select * from `myfile.json`
> select * from `/mysdir/myfile.json`
> select * from `/mytdir/mysdir/myfile.json`
> ::all produce::
> a, b, c
> 1, 2, 3
> 4, 5, 6
>
> select dir0, a, b, c from `/mysdir/myfile.json`
>
> dir0 a, b, c
> mysdir, 1, 2, 3
> mysdir, 4, 5, 6
>
> select dir0, a, b, c from `/mytdir/mysdir/myfile.json`
>
> dir0 a, b, c
> mytdir, 1, 2, 3
> mytdir, 4, 5, 6
>
>
>
>
> On Thu, Apr 23, 2015 at 5:42 PM, Aman Sinha <asinha@maprtech.com> wrote:
>
> > Seems reasonable, as long as SELECT * also returns the dir# columns.
> >
> > On Thu, Apr 23, 2015 at 2:34 PM, Jacques Nadeau <jacques@apache.org>
> > wrote:
> >
> > > Hey guys,
> > >
> > > I've been thinking that always showing dir# columns seems to alter data
> > > returned from Drill depending on how you select the directory.  I'd
> > propose
> > > that we make it so that we only return dir# columns when they are
> > > explicitly requested.
> > >
> > > Thoughts?
> > >
> >
>

--14dae9cc94960ca21405146c3008--