Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D42F18DB5 for ; Wed, 29 Apr 2015 20:50:18 +0000 (UTC) Received: (qmail 23180 invoked by uid 500); 29 Apr 2015 20:50:17 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 23125 invoked by uid 500); 29 Apr 2015 20:50:17 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 23114 invoked by uid 500); 29 Apr 2015 20:50:17 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 23108 invoked by uid 99); 29 Apr 2015 20:50:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2015 20:50:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 29E4A1DBA89; Wed, 29 Apr 2015 20:50:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8913123283075545242==" MIME-Version: 1.0 Subject: Review Request 33684: DRILL-2889: Rename JdbcTest to JdbcTestBase. From: "Daniel Barclay" To: "Parth Chandra" , "Hanifi Gunes" Cc: "Daniel Barclay" , "drill" Date: Wed, 29 Apr 2015 20:50:18 -0000 Message-ID: <20150429205018.17829.3572@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Daniel Barclay" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33684/ X-Sender: "Daniel Barclay" Reply-To: "Daniel Barclay" X-ReviewRequest-Repository: drill-git --===============8913123283075545242== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33684/ ----------------------------------------------------------- Review request for drill, Hanifi Gunes and Parth Chandra. Bugs: DRILL-2889 https://issues.apache.org/jira/browse/DRILL-2889 Repository: drill-git Description ------- Renamed `JdbcTest` to `JdbcTestBase` to follow "`*Base`" pattern of (some) test base classes and avoid confusion/conflicted with "`*Test`" pattern of _unit-level_ unit test classes).. Diffs ----- exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 0f3d838 exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java e486898 exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTestBase.java PRE-CREATION exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java eced72b exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 7e3a51b exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java 38c6d46 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2439GetBooleanFailsSayingWrongTypeBugTest.java bd993fd exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2461IntervalsBreakInfoSchemaBugTest.java d9ac3c7 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2463GetNullsFailedWithAssertionsBugTest.java 1d1361a exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java 3282945 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcDataTest.java f257c98 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestActionBase.java 15fe219 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 5c0a0e5 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java aa68e9f exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java a8f47c6 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 843c1c7 Diff: https://reviews.apache.org/r/33684/diff/ Testing ------- Ran regular tests; no new failures. Thanks, Daniel Barclay --===============8913123283075545242==--