Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8800317BB2 for ; Tue, 28 Apr 2015 01:00:11 +0000 (UTC) Received: (qmail 55315 invoked by uid 500); 28 Apr 2015 01:00:11 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 55264 invoked by uid 500); 28 Apr 2015 01:00:11 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 55213 invoked by uid 500); 28 Apr 2015 01:00:11 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 55206 invoked by uid 99); 28 Apr 2015 01:00:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Apr 2015 01:00:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A13E31DB9AD; Tue, 28 Apr 2015 01:00:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3483270715520680255==" MIME-Version: 1.0 Subject: Review Request 33610: DRILL-2872: Result from json file returns data from repeated type fields as "null" From: "Parth Chandra" To: "Mehant Baid" , "Hanifi Gunes" Cc: "drill" , "Parth Chandra" Date: Tue, 28 Apr 2015 01:00:11 -0000 Message-ID: <20150428010011.17829.94169@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Parth Chandra" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33610/ X-Sender: "Parth Chandra" Reply-To: "Parth Chandra" X-ReviewRequest-Repository: drill-git --===============3483270715520680255== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33610/ ----------------------------------------------------------- Review request for drill, Hanifi Gunes and Mehant Baid. Repository: drill-git Description ------- DRILL-2872: Result from json file returns data from repeated type fields as "null" The isSet method for HolderReaderImpl(s) checks the isSet for the 'holder' member. For repeated types, though, it needs to check the 'repeatedHolder' member. Diffs ----- exec/java-exec/src/main/codegen/templates/HolderReaderImpl.java 7d4ff318cde462bbf5c29e38d25f0ac15eac94f4 exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestComplexTypeReader.java 933352340b8347b120cf9c3c8dbf8c2ccfcad0c6 exec/java-exec/src/test/resources/DRILL-2872-result.json PRE-CREATION exec/java-exec/src/test/resources/complex_student.json PRE-CREATION Diff: https://reviews.apache.org/r/33610/diff/ Testing ------- All regression and unit tests. Added new unit test for this case. Thanks, Parth Chandra --===============3483270715520680255==--