Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A11DE175E8 for ; Mon, 27 Apr 2015 23:02:26 +0000 (UTC) Received: (qmail 26944 invoked by uid 500); 27 Apr 2015 23:02:26 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 26893 invoked by uid 500); 27 Apr 2015 23:02:26 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 26882 invoked by uid 500); 27 Apr 2015 23:02:26 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 26875 invoked by uid 99); 27 Apr 2015 23:02:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Apr 2015 23:02:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F2CB51DB9A0; Mon, 27 Apr 2015 23:02:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3386995652757218889==" MIME-Version: 1.0 Subject: Re: Review Request 33602: DRILL-2888 C++ Client: Setting MIN and MAX for y2038 time library for Windows platform From: "Alexander zarei" To: "Xiao Meng" , "Norris Lee" , "Parth Chandra" Cc: "Alexander zarei" , "drill" Date: Mon, 27 Apr 2015 23:02:26 -0000 Message-ID: <20150427230226.26755.52621@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander zarei" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33602/ X-Sender: "Alexander zarei" References: <20150427224026.26755.28117@reviews.apache.org> In-Reply-To: <20150427224026.26755.28117@reviews.apache.org> Reply-To: "Alexander zarei" X-ReviewRequest-Repository: drill-git --===============3386995652757218889== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33602/ ----------------------------------------------------------- (Updated April 27, 2015, 11:02 p.m.) Review request for drill, Norris Lee, Parth Chandra, and Xiao Meng. Repository: drill-git Description ------- Edge cases fail if the values are not correctly set as per the submitted patch. Basically the scope within which time values are processes/transmitted correctly expands by the correct values. Diffs ----- contrib/native/client/src/clientlib/y2038/time64_limits.h e640cae Diff: https://reviews.apache.org/r/33602/diff/ Testing (updated) ------- Test with query submitter under the following platforms: Darwin universal Linux x8664 Windows x64 and Win32 ./querySubmitter query='SELECT * FROM `hive`.`default`.`real_table`' type=sql connectStr=local=192.168.39.44:31010 api=async logLevel=fatal user=MYUSER password=MYPASSWORD > test2.txt Thanks, Alexander zarei --===============3386995652757218889==--