Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D77C417360 for ; Tue, 21 Apr 2015 16:11:11 +0000 (UTC) Received: (qmail 84000 invoked by uid 500); 21 Apr 2015 16:11:11 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 83948 invoked by uid 500); 21 Apr 2015 16:11:11 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 83937 invoked by uid 500); 21 Apr 2015 16:11:11 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 83931 invoked by uid 99); 21 Apr 2015 16:11:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2015 16:11:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B98B51CE0CC; Tue, 21 Apr 2015 16:11:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6119806724927683044==" MIME-Version: 1.0 Subject: Re: Review Request 32273: DRILL-2408: Invalid (0 length) parquet file created by CTAS From: "abdelhakim deneche" To: "Aman Sinha" , "Jason Altekruse" Cc: "abdelhakim deneche" , "drill" Date: Tue, 21 Apr 2015 16:11:12 -0000 Message-ID: <20150421161112.2948.38000@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "abdelhakim deneche" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/32273/ X-Sender: "abdelhakim deneche" References: <20150331001955.16792.53628@reviews.apache.org> In-Reply-To: <20150331001955.16792.53628@reviews.apache.org> Reply-To: "abdelhakim deneche" X-ReviewRequest-Repository: drill-git --===============6119806724927683044== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32273/ ----------------------------------------------------------- (Updated April 21, 2015, 4:11 p.m.) Review request for drill, Aman Sinha and Jason Altekruse. Changes ------- ParquetRecordWriter does not create a new file/folder until it's flushing data to the file. Bugs: DRILL-2408 https://issues.apache.org/jira/browse/DRILL-2408 Repository: drill-git Description ------- I updated ParquetRecordWriter to delete the last file created if it's empty (no records written to it). I also added two unit tests one that checks the default case where we try to create a table using a query that returns 0 rows, the second case can happen if the ParquetRecordWriter flushes it's content just after writing the last record, it will then create a new empty file. Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java 3e35721 exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 89837e7 Diff: https://reviews.apache.org/r/32273/diff/ Testing ------- - Added 2 unit tests to TestParquetWriter - Unit tests are passing Thanks, abdelhakim deneche --===============6119806724927683044==--