Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 11F7017D38 for ; Mon, 20 Apr 2015 21:31:12 +0000 (UTC) Received: (qmail 25687 invoked by uid 500); 20 Apr 2015 21:31:05 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 25636 invoked by uid 500); 20 Apr 2015 21:31:05 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 25625 invoked by uid 500); 20 Apr 2015 21:31:05 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 25619 invoked by uid 99); 20 Apr 2015 21:31:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Apr 2015 21:31:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EE6831D9664; Mon, 20 Apr 2015 21:31:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9052104093359151900==" MIME-Version: 1.0 Subject: Re: Review Request 33289: DRILL-2350: Improve exception handling and error messages in JSON reader. From: "Parth Chandra" To: "abdelhakim deneche" , "Jason Altekruse" Cc: "Parth Chandra" , "drill" Date: Mon, 20 Apr 2015 21:31:06 -0000 Message-ID: <20150420213106.2948.91148@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Parth Chandra" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33289/ X-Sender: "Parth Chandra" References: <20150420204456.2948.64120@reviews.apache.org> In-Reply-To: <20150420204456.2948.64120@reviews.apache.org> Reply-To: "Parth Chandra" X-ReviewRequest-Repository: drill-git --===============9052104093359151900== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33289/ ----------------------------------------------------------- (Updated April 20, 2015, 9:31 p.m.) Review request for drill, abdelhakim deneche and Jason Altekruse. Changes ------- Updated with Hakim's suggestion Repository: drill-git Description ------- DRILL-2350: Improve exception handling and error messages in JSON reader. Errors reported from the JSON reader will now look like the following: Query failed: UNSUPPORTED_OPERATION ERROR: In a list of type FLOAT8, encountered a value of type BIGINT. Drill does not support lists of different types. File: /Users/pchandra/work/data/test/DRILL-2350.json Record: 1 Line: 2 Column: 23 Field: loc [c4b33cca-0a52-4126-a300-2ab91d0ed9d1 on localhost:31010] Diffs (updated) ----- exec/java-exec/src/main/codegen/includes/vv_imports.ftl 371d8d0 exec/java-exec/src/main/codegen/templates/ListWriters.java 29708d7 exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java b41de31 exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonProcessor.java b310818 exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/reader/BaseJsonProcessor.java 718bb09 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java c196fd2 exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java 8b09e80 exec/java-exec/src/test/resources/jsoninput/DRILL-2350.json PRE-CREATION Diff: https://reviews.apache.org/r/33289/diff/ Testing ------- All unit tests. Thanks, Parth Chandra --===============9052104093359151900==--