Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4193517901 for ; Wed, 15 Apr 2015 14:51:34 +0000 (UTC) Received: (qmail 29409 invoked by uid 500); 15 Apr 2015 14:51:34 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 29358 invoked by uid 500); 15 Apr 2015 14:51:34 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 29347 invoked by uid 500); 15 Apr 2015 14:51:33 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 29342 invoked by uid 99); 15 Apr 2015 14:51:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2015 14:51:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E44201D303A; Wed, 15 Apr 2015 14:51:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6790871692800776421==" MIME-Version: 1.0 Subject: Re: Review Request 33209: DRILL-2341: Type information is lost if list of fields is specified during create view From: "Venki Korukanti" To: "Jinfeng Ni" Cc: "Venki Korukanti" , "drill" Date: Wed, 15 Apr 2015 14:51:35 -0000 Message-ID: <20150415145135.1421.43825@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Venki Korukanti" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33209/ X-Sender: "Venki Korukanti" References: <20150415054534.14115.76869@reviews.apache.org> In-Reply-To: <20150415054534.14115.76869@reviews.apache.org> Reply-To: "Venki Korukanti" X-ReviewRequest-Repository: drill-git --===============6790871692800776421== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 15, 2015, 5:45 a.m., Jinfeng Ni wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java, line 114 > > > > > > This part of logic is quite similar in ViewHandler and CreateTableHandler. Is it possible that we move the common code to a helper method (check the field count, *, create the rename project, etc), so that both of the Handlers could call this method? Good idea. Refactored in v2 patch. - Venki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33209/#review80159 ----------------------------------------------------------- On April 15, 2015, 2:50 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33209/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 2:50 p.m.) > > > Review request for drill and Jinfeng Ni. > > > Repository: drill-git > > > Description > ------- > > Create a cast to rename the view definition query row type to view field list specified in CREATE VIEW statement. > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java cacf26b > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 300d65d > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java 4347249 > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 325f770 > exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 578eace > > Diff: https://reviews.apache.org/r/33209/diff/ > > > Testing > ------- > > Includes unittests. > > > Thanks, > > Venki Korukanti > > --===============6790871692800776421==--