Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5FCA217369 for ; Wed, 15 Apr 2015 00:42:22 +0000 (UTC) Received: (qmail 48776 invoked by uid 500); 15 Apr 2015 00:42:22 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 48721 invoked by uid 500); 15 Apr 2015 00:42:22 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 48710 invoked by uid 500); 15 Apr 2015 00:42:21 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 48705 invoked by uid 99); 15 Apr 2015 00:42:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2015 00:42:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0E2F91D9BDE; Wed, 15 Apr 2015 00:42:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7413789636431543145==" MIME-Version: 1.0 Subject: Re: Review Request 33180: DRILL-2181 Throw proper error message when flatten is used within an 'order by' or 'group by' From: "Sean Hsuan-Yi Chu" To: "Jason Altekruse" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Wed, 15 Apr 2015 00:42:23 -0000 Message-ID: <20150415004223.14115.10832@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sean Hsuan-Yi Chu" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/33180/ X-Sender: "Sean Hsuan-Yi Chu" References: <20150414180727.31554.4566@reviews.apache.org> In-Reply-To: <20150414180727.31554.4566@reviews.apache.org> Reply-To: "Sean Hsuan-Yi Chu" X-ReviewRequest-Repository: drill-git --===============7413789636431543145== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33180/ ----------------------------------------------------------- (Updated April 15, 2015, 12:42 a.m.) Review request for drill and Jason Altekruse. Changes ------- update description Bugs: DRILL-2181 https://issues.apache.org/jira/browse/DRILL-2181 Repository: drill-git Description ------- Flatten function in order by, group by, distinct, aggregate functions is disabled Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 4830fe1 exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java f62f060 Diff: https://reviews.apache.org/r/33180/diff/ Testing (updated) ------- tpch, functional (except for the cases which are meant to be removed), unit Thanks, Sean Hsuan-Yi Chu --===============7413789636431543145==--