Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9566C175B5 for ; Thu, 9 Apr 2015 16:59:28 +0000 (UTC) Received: (qmail 92815 invoked by uid 500); 9 Apr 2015 16:59:28 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 92757 invoked by uid 500); 9 Apr 2015 16:59:28 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 92743 invoked by uid 500); 9 Apr 2015 16:59:28 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 92738 invoked by uid 99); 9 Apr 2015 16:59:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2015 16:59:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B11D81D3630; Thu, 9 Apr 2015 16:59:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4559733783377135352==" MIME-Version: 1.0 Subject: Re: Review Request 32947: DRILL-2717: Union-All reports new schema change when there is actually no From: "Sean Hsuan-Yi Chu" To: "Aman Sinha" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Thu, 09 Apr 2015 16:59:29 -0000 Message-ID: <20150409165929.1489.87865@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sean Hsuan-Yi Chu" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/32947/ X-Sender: "Sean Hsuan-Yi Chu" References: <20150409064813.1489.81425@reviews.apache.org> In-Reply-To: <20150409064813.1489.81425@reviews.apache.org> Reply-To: "Sean Hsuan-Yi Chu" X-ReviewRequest-Repository: drill-git --===============4559733783377135352== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 9, 2015, 6:48 a.m., Aman Sinha wrote: > > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java, line 444 > > > > > > You should name the columns explicitly in the subquery instead of relying on EXPR$0 which is a planner generated name and could change in the future. I named this column explicitly as 'col0' - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32947/#review79486 ----------------------------------------------------------- On April 8, 2015, 12:34 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32947/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 12:34 a.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-2717 > https://issues.apache.org/jira/browse/DRILL-2717 > > > Repository: drill-git > > > Description > ------- > > The upstream message returned by Union-All (when innerNext is called on Union-All) is corrected > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 61de3a4 > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 7033013 > > Diff: https://reviews.apache.org/r/32947/diff/ > > > Testing > ------- > > QA, unit > > > Thanks, > > Sean Hsuan-Yi Chu > > --===============4559733783377135352==--