Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A64517687 for ; Wed, 8 Apr 2015 19:10:49 +0000 (UTC) Received: (qmail 16277 invoked by uid 500); 8 Apr 2015 19:10:41 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 16220 invoked by uid 500); 8 Apr 2015 19:10:41 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 16197 invoked by uid 500); 8 Apr 2015 19:10:40 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 16190 invoked by uid 99); 8 Apr 2015 19:10:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2015 19:10:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 94A9C1D71D3; Wed, 8 Apr 2015 19:10:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7572427387691422189==" MIME-Version: 1.0 Subject: Re: Review Request 32949: DRILL-2718: Handle counting and status of sent batches by FragmentContext From: "Steven Phillips" To: "Jacques Nadeau" , "Chris Westin" Cc: "drill" , "Steven Phillips" Date: Wed, 08 Apr 2015 19:10:38 -0000 Message-ID: <20150408191038.18051.3696@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Steven Phillips" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/32949/ X-Sender: "Steven Phillips" References: <20150408005713.18051.80550@reviews.apache.org> In-Reply-To: <20150408005713.18051.80550@reviews.apache.org> Reply-To: "Steven Phillips" X-ReviewRequest-Repository: drill-git --===============7572427387691422189== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32949/ ----------------------------------------------------------- (Updated April 8, 2015, 7:10 p.m.) Review request for drill, Chris Westin and Jacques Nadeau. Changes ------- A couple of small changes. Of most interest, in SendingAccountor, continue waiting after catching InterruptedException Repository: drill-git Description ------- Creates wrapper classes FragmentDataTunnel and FragmentUserDataTunnel which wrap the DataTunnel and UserClientConnection, respectively, allowing us to use DataTunnels and UserClientConnections from a global pool, but track pending batches and send status at the FragmentContext level. Consolidates the various StatusListener implementations used by the various senders and instead uses just one implementation. Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 18b93e9 exec/java-exec/src/main/java/org/apache/drill/exec/ops/SendingAccountor.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java a00df9d exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java 8038527 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java 21fc800 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SingleSenderCreator.java 1ef7bbd exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java d17fdd4 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java 6a73cdd exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/Partitioner.java 9d6e98f exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerTemplate.java 33d6f95 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/StatusHandler.java 5e21878 exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java 8022c95 Diff: https://reviews.apache.org/r/32949/diff/ Testing ------- No new functionality, so no new tests. Current tests all pass. Thanks, Steven Phillips --===============7572427387691422189==--