Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4FB4617C12 for ; Fri, 3 Apr 2015 16:16:59 +0000 (UTC) Received: (qmail 14364 invoked by uid 500); 3 Apr 2015 16:16:59 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 14314 invoked by uid 500); 3 Apr 2015 16:16:59 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 14302 invoked by uid 500); 3 Apr 2015 16:16:58 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 14297 invoked by uid 99); 3 Apr 2015 16:16:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2015 16:16:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 30FE61CC035; Fri, 3 Apr 2015 16:16:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1329937279698555038==" MIME-Version: 1.0 Subject: Re: Review Request 32634: DRILL-2612: Union All involving empty JSON file on right input to union all returns zero results From: "Aman Sinha" To: "Aman Sinha" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Fri, 03 Apr 2015 16:16:57 -0000 Message-ID: <20150403161657.16792.22746@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aman Sinha" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/32634/ X-Sender: "Aman Sinha" References: <20150402183804.16791.66357@reviews.apache.org> In-Reply-To: <20150402183804.16791.66357@reviews.apache.org> Reply-To: "Aman Sinha" X-ReviewRequest-Repository: drill-git --===============1329937279698555038== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32634/#review78792 ----------------------------------------------------------- This looks like the wrong patch.. can you pls upload the correct patch ? - Aman Sinha On April 2, 2015, 6:38 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32634/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 6:38 p.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-2612 > https://issues.apache.org/jira/browse/DRILL-2612 > > > Repository: drill-git > > > Description > ------- > > Union-All can work even when either or both sides do not have any data > > > Diffs > ----- > > protocol/pom.xml f7d907d > protocol/src/main/java/org/apache/drill/common/types/TypeProtos.java 67beed1 > protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java 2502701 > protocol/src/main/java/org/apache/drill/exec/proto/BitData.java b4a2f19 > protocol/src/main/java/org/apache/drill/exec/proto/CoordinationProtos.java 45321ea > protocol/src/main/java/org/apache/drill/exec/proto/ExecProtos.java ca4f294 > protocol/src/main/java/org/apache/drill/exec/proto/GeneralRPCProtos.java 32a63e5 > protocol/src/main/java/org/apache/drill/exec/proto/SchemaDefProtos.java 024774a > protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java 00a4905 > protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java 330e774 > > Diff: https://reviews.apache.org/r/32634/diff/ > > > Testing > ------- > > QA, unit all passed > > > Thanks, > > Sean Hsuan-Yi Chu > > --===============1329937279698555038==--