Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3FC717A23 for ; Fri, 3 Apr 2015 00:15:10 +0000 (UTC) Received: (qmail 40706 invoked by uid 500); 3 Apr 2015 00:15:10 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 40640 invoked by uid 500); 3 Apr 2015 00:15:10 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 40627 invoked by uid 500); 3 Apr 2015 00:15:10 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 40622 invoked by uid 99); 3 Apr 2015 00:15:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2015 00:15:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9AD7F1D70AA; Fri, 3 Apr 2015 00:15:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0029612784138888703==" MIME-Version: 1.0 Subject: Re: Review Request 32590: DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is corrected From: "Aman Sinha" To: "Aman Sinha" Cc: "Sean Hsuan-Yi Chu" , "drill" Date: Fri, 03 Apr 2015 00:15:08 -0000 Message-ID: <20150403001508.16791.97882@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aman Sinha" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/32590/ X-Sender: "Aman Sinha" References: <20150401213901.16792.62677@reviews.apache.org> In-Reply-To: <20150401213901.16792.62677@reviews.apache.org> Reply-To: "Aman Sinha" X-ReviewRequest-Repository: drill-git --===============0029612784138888703== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32590/#review78745 ----------------------------------------------------------- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java It's not clear to me why we have to check specifically for NumberFormatException here...this is just another type of IllegalArgumentException. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java For schema equivalence why do we need a new method ? Did you try equals() ? Having a separate method can be prone to bugs later if it gets out of sync with attributes of the class. - Aman Sinha On April 1, 2015, 9:39 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32590/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 9:39 p.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-2591.1 > https://issues.apache.org/jira/browse/DRILL-2591.1 > > > Repository: drill-git > > > Description > ------- > > DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is corrected > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 806104a > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 1aa033b > exec/java-exec/src/main/java/org/apache/drill/exec/record/BatchSchema.java da2e9eb > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 1ebb534 > exec/java-exec/src/test/resources/store/json/dateData.json PRE-CREATION > exec/java-exec/src/test/resources/store/json/timeStmpData.json PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q18.tsv PRE-CREATION > > Diff: https://reviews.apache.org/r/32590/diff/ > > > Testing > ------- > > QA, unit all passed > > > Thanks, > > Sean Hsuan-Yi Chu > > --===============0029612784138888703==--