Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Content-Type: multipart/alternative;
 boundary="===============2464108896887881032=="
MIME-Version: 1.0
Subject: Re: Review Request 32494: DRILL-2565: Add AlreadyClosedSqlException,
 some key checks, and test for future DRILL-2489 fix.
From: "Parth Chandra" <pchandra@maprtech.com>
To: "Mehant Baid" <baid.mehant@gmail.com>,
 "Parth Chandra" <pchandra@maprtech.com>
Cc: "drill" <drill-dev@incubator.apache.org>,
 "Daniel Barclay" <dbarclay@maprtech.com>
Date: Thu, 02 Apr 2015 20:56:42 -0000
Message-ID: <20150402205642.16791.71143@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Parth Chandra" <noreply@reviews.apache.org>
References: <20150331213228.16792.31976@reviews.apache.org>
In-Reply-To: <20150331213228.16792.31976@reviews.apache.org>
Reply-To: "Parth Chandra" <pchandra@maprtech.com>

--===============2464108896887881032==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32494/#review78720
-----------------------------------------------------------


exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
<https://reviews.apache.org/r/32494/#comment127675>

    Did you check this with SQLLine? If a query is returning a large result set and the user cancels, the result set is closed as part of the main thread but another thread will still call next(). This will cause an ugly exception to be printed even though this is a normal case.


exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java
<https://reviews.apache.org/r/32494/#comment127676>

    I think the parent throws an UnsupportedOperationException for the update methods. Don't see why we need to override this.


- Parth Chandra


On March 31, 2015, 9:32 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32494/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 9:32 p.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Bugs: DRILL-2565
>     https://issues.apache.org/jira/browse/DRILL-2565
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - Created AlreadyClosedSqlException.
> - (Moved JdbcApiSqlException to be subclass of SQLNonTransientException.)
> - Created test Drill2489CallsAfterCloseThrowExceptionsTest for eventual fixing of DRILL-2489.
>    - (Is partial:  Covers Connection, Statement, and ResultSet.)
>    - (Is interim:  Most methods' test disabled with @Ignore.)
> - Added already-closed checking in key places, especially those that involve communication and could hang for a while rather than dying quickly (e.g., Statement.execute...(...)).
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java PRE-CREATION 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java e590778 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java ca1648d 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 0ce33f4 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java d934c7c 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java 7b04371 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java d6b05fb 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32494/diff/
> 
> 
> Testing
> -------
> 
> Ran new specific tests.
> 
> Run existing tests; no new problems.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


--===============2464108896887881032==--