Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Content-Type: multipart/alternative;
 boundary="===============7301796722478991134=="
MIME-Version: 1.0
Subject: Re: Review Request 32590: DRILL-2591: In UnionAllRecordBactch,
 the mechansim to detect schema change is corrected
From: "Sean Hsuan-Yi Chu" <hsuanyi@usc.edu>
To: "Aman Sinha" <asinha@maprtech.com>
Cc: "Sean Hsuan-Yi Chu" <hsuanyi@usc.edu>,
 "drill" <drill-dev@incubator.apache.org>
Date: Wed, 01 Apr 2015 17:43:43 -0000
Message-ID: <20150401174343.16791.16034@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sean Hsuan-Yi Chu" <noreply@reviews.apache.org>
References: <20150329172846.16792.57767@reviews.apache.org>
In-Reply-To: <20150329172846.16792.57767@reviews.apache.org>
Reply-To: "Sean Hsuan-Yi Chu" <hsuanyi@usc.edu>

--===============7301796722478991134==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On March 29, 2015, 5:28 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 357
> > <https://reviews.apache.org/r/32590/diff/1/?file=908305#file908305line357>
> >
> >     The error message says 'right input' - it should be 'left input'

Updated!


> On March 29, 2015, 5:28 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 356
> > <https://reviews.apache.org/r/32590/diff/1/?file=908305#file908305line356>
> >
> >     Same as above.

Same as above.


> On March 29, 2015, 5:28 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, line 330
> > <https://reviews.apache.org/r/32590/diff/1/?file=908305#file908305line330>
> >
> >     This does not look right...the check here is checking schema change status of the outgoing batch of UnionAll, wherease you are interested in the incoming batch.

A new approach is to memorize the schema for the first record batch (from the left and right sides). And just the schemas for the subsequent record batches with the memorized schema. If they are different, that means schema has been changed.


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32590/#review78163
-----------------------------------------------------------


On March 27, 2015, 8:33 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32590/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 8:33 p.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-2591.1
>     https://issues.apache.org/jira/browse/DRILL-2591.1
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is corrected
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 806104a 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java 1aa033b 
>   exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 520c204 
>   exec/java-exec/src/test/resources/store/json/dateData.json PRE-CREATION 
>   exec/java-exec/src/test/resources/store/json/timeStmpData.json PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q18.tsv PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32590/diff/
> 
> 
> Testing
> -------
> 
> QA, unit all passed
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


--===============7301796722478991134==--