drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinfeng Ni <...@apache.org>
Subject Re: [DISCUSS] improve physical plan formatting
Date Mon, 13 Apr 2015 20:25:14 GMT
+1.

Increased indentation is required not only for join, but for any operator
which takes more than 1 inputs.  Union / Union All would be another
example.



On Mon, Apr 13, 2015 at 12:39 PM, Tomer Shiran <tshiran@gmail.com> wrote:

> +1
>
>
> On Fri, Apr 10, 2015 at 4:23 PM, Steven Phillips <sphillips@maprtech.com>
> wrote:
>
> > I find the current format for physical plans, where we indent for every
> > operator, but keep both sides of the join at the same indentation the
> same,
> > is very difficult to read, especially when we have several joins.
> >
> > I think it would be easier to read if we kept sequential operators at the
> > same indentation, but increased indentation only when there is a join,
> and
> > include some marks to show the connection between the sides of the join
> and
> > the join operator.
> >
> > I created a gist with an example:
> >
> > https://gist.github.com/StevenMPhillips/74a6bf655175aabd14c0
> >
> >
> >
> > --
> >  Steven Phillips
> >  Software Engineer
> >
> >  mapr.com
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message