drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 33685: DRILL-2904: Fix wrong "before rows" message to "after rows" message
Date Wed, 29 Apr 2015 20:50:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33685/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-2904
    https://issues.apache.org/jira/browse/DRILL-2904


Repository: drill-git


Description
-------

- Worked around Avatica isBeforeFirst()/next() bug.
- Fixed corresponding error in unit test.
- Also fixed other backwards test-failure message wording.


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java 2b20f23 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java 64be408 

Diff: https://reviews.apache.org/r/33685/diff/


Testing
-------

Manually checked (stepped through) unit test runs before and after fixing unit test.

Ran regular tests; no new failures.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message