drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 33684: DRILL-2889: Rename JdbcTest to JdbcTestBase.
Date Wed, 29 Apr 2015 20:50:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33684/
-----------------------------------------------------------

Review request for drill, Hanifi Gunes and Parth Chandra.


Bugs: DRILL-2889
    https://issues.apache.org/jira/browse/DRILL-2889


Repository: drill-git


Description
-------

Renamed `JdbcTest` to `JdbcTestBase` to follow "`*Base`" pattern of (some) test base classes
and avoid confusion/conflicted with "`*Test`" pattern of _unit-level_ unit test classes)..


Diffs
-----

  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 0f3d838

  exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java e486898 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTestBase.java PRE-CREATION 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java eced72b

  exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 7e3a51b

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java
38c6d46 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2439GetBooleanFailsSayingWrongTypeBugTest.java
bd993fd 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2461IntervalsBreakInfoSchemaBugTest.java
d9ac3c7 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2463GetNullsFailedWithAssertionsBugTest.java
1d1361a 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
3282945 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcDataTest.java f257c98 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestActionBase.java 15fe219 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 5c0a0e5 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestAggregateFunctionsQuery.java aa68e9f

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java a8f47c6 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 843c1c7 

Diff: https://reviews.apache.org/r/33684/diff/


Testing
-------

Ran regular tests; no new failures.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message