drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 33683: DRILL-2887: Fix bad applications of JdbcTest.connect(...).
Date Wed, 29 Apr 2015 20:50:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33683/
-----------------------------------------------------------

Review request for drill, Hanifi Gunes and Parth Chandra.


Bugs: DRILL-2887
    https://issues.apache.org/jira/browse/DRILL-2887


Repository: drill-git


Description
-------

- Removed use of Jdbc.connect() from:
  -- Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest
  -- Drill2489CallsAfterCloseThrowExceptionsTest
- Added (manual) test for use of auto-resetting connection.  [JdbcTest]
- Documented need to avoid Jdbc.connect() in above and similar tests.
- Add "document" TODO for JdbcTest.


Diffs
-----

  exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTransactionMethodsTest.java dd92c9b

  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 0f3d838

  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataTest.java 8b885a4 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java e486898 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java eced72b

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java 78a8af2

  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java
38c6d46 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2463GetNullsFailedWithAssertionsBugTest.java
1d1361a 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
3282945 

Diff: https://reviews.apache.org/r/33683/diff/


Testing
-------

Ran regular tests; no new failures.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message