drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdelhakim deneche" <adene...@gmail.com>
Subject Re: Review Request 33222: DRILL-2292: CTAS broken when we have repeated maps
Date Mon, 27 Apr 2015 01:13:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33222/
-----------------------------------------------------------

(Updated April 27, 2015, 1:13 a.m.)


Review request for drill, Hanifi Gunes and Steven Phillips.


Bugs: DRILL-2292
    https://issues.apache.org/jira/browse/DRILL-2292


Repository: drill-git


Description
-------

- fixed _RepeatedMapReaderImpl.setPosition()_ to handle when the index is negative or _NO_VALUES_
- added unit test _TestRepeatedReaders.testReadNestedRepeatedMap()_


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java
767c366 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java
71a5017 
  exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java PRE-CREATION

  exec/java-exec/src/test/resources/parquet/2292.rl_rl.json PRE-CREATION 
  exec/java-exec/src/test/resources/parquet/2292.rl_rm.json PRE-CREATION 
  exec/java-exec/src/test/resources/parquet/2292.rm_m_rm.json PRE-CREATION 
  exec/java-exec/src/test/resources/parquet/2292.rm_rl.json PRE-CREATION 
  exec/java-exec/src/test/resources/parquet/2292.rm_rm.json PRE-CREATION 

Diff: https://reviews.apache.org/r/33222/diff/


Testing (updated)
-------

All unit tests are passing along with functional, customer and tpch100


Thanks,

abdelhakim deneche


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message