drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 33442: DRILL-2811: Allow direct connection to drillbit from DrillClient
Date Thu, 23 Apr 2015 01:27:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33442/#review81259
-----------------------------------------------------------


Looks ready to ship except this minor naming issue.


exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
<https://reviews.apache.org/r/33442/#comment131550>

    We may want to pick another name that is accurate and more appropriate for user consuption.
I would propose address or endpoint or master.


- Hanifi Gunes


On April 22, 2015, 4:44 p.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33442/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 4:44 p.m.)
> 
> 
> Review request for drill, Daniel Barclay, Hanifi Gunes, and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2811: Allow direct connection to drillbit from DrillClient
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 0d29f600fc151931601c7a922015d136dc62224a

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java de08cda6cf831343b42b4d15fa97bcb2c90c7305

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 3fdbf840f9d49dd37fa0cf43872c48f9941dc696

> 
> Diff: https://reviews.apache.org/r/33442/diff/
> 
> 
> Testing
> -------
> 
> Tested using sqlline
> 
> As the connection string use : 
> 
> sqlline -u "jdbc:drill:local=localhost:31010"  -n admin -p admin
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message