drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 33222: DRILL-2292: CTAS broken when we have repeated maps
Date Thu, 23 Apr 2015 01:14:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33222/#review81258
-----------------------------------------------------------



exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java
<https://reviews.apache.org/r/33222/#comment131549>

    we should not need this.


- Hanifi Gunes


On April 21, 2015, 4:14 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33222/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 4:14 p.m.)
> 
> 
> Review request for drill, Hanifi Gunes and Steven Phillips.
> 
> 
> Bugs: DRILL-2292
>     https://issues.apache.org/jira/browse/DRILL-2292
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - fixed _RepeatedMapReaderImpl.setPosition()_ to handle when the index is negative or
_NO_VALUES_
> - added unit test _TestRepeatedReaders.testReadNestedRepeatedMap()_
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java
767c366 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java
71a5017 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java PRE-CREATION

>   exec/java-exec/src/test/resources/parquet/2292.rl_rl.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rl_rm.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rm_m_rm.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rm_rl.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rm_rm.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33222/diff/
> 
> 
> Testing
> -------
> 
> one final round of testing, I will update the results of the tests once they are done
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message