drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 33442: DRILL-2811: Allow direct connection to drillbit from DrillClient
Date Wed, 22 Apr 2015 18:37:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33442/#review81187
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
<https://reviews.apache.org/r/33442/#comment131442>

    Where is the new "local" property specified?  If nowhere else, then at least specify it
here in the code for now (i.e., say that it's hostname/address, colon, and port number), so
that there's some doc. in the code to point the technical writers to.



exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
<https://reviews.apache.org/r/33442/#comment131439>

    Say at least a little about what isDirect means.



exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
<https://reviews.apache.org/r/33442/#comment131438>

    Please put spaces around assignment "=" (as is normal and as the adjacent and other Drill
code has it).



exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
<https://reviews.apache.org/r/33442/#comment131441>

    Add "final".  (It's set once in each branch of the isDirectConnection if statement, right?)



exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
<https://reviews.apache.org/r/33442/#comment131445>

    Why "local"?
    
    What exactly does "local" mean?  (The property apparently refers to a different machine,
so that's not local.)
    
    (Code identifiers use the word "direct" and the parameter uses the word "local"--should
one be use other word instead?
    
    Isn't this specifying which Drillbit to use as the master coordinator, or whatever we
actually call that role, for this JDBC connection?  Would a name that's a noun or noun phrase
and refers to that master be clearer?



exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java
<https://reviews.apache.org/r/33442/#comment131440>

    The remainder of the affected code didn't get indented.


- Daniel Barclay


On April 22, 2015, 4:44 p.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33442/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 4:44 p.m.)
> 
> 
> Review request for drill, Daniel Barclay, Hanifi Gunes, and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-2811: Allow direct connection to drillbit from DrillClient
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 0d29f600fc151931601c7a922015d136dc62224a

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java de08cda6cf831343b42b4d15fa97bcb2c90c7305

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 3fdbf840f9d49dd37fa0cf43872c48f9941dc696

> 
> Diff: https://reviews.apache.org/r/33442/diff/
> 
> 
> Testing
> -------
> 
> Tested using sqlline
> 
> As the connection string use : 
> 
> sqlline -u "jdbc:drill:local=localhost:31010"  -n admin -p admin
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message