drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 33345: DRILL-2829 Info. schema hygiene (for upcoming fixes)
Date Wed, 22 Apr 2015 18:02:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33345/#review81189
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On April 20, 2015, 4:24 a.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33345/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 4:24 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Bugs: DRILL-2829
>     https://issues.apache.org/jira/browse/DRILL-2829
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - Clarified column constant names.  Also grouped and ordered them.
> - Added/applied constant for catalog name "DRILL".
> - Fixed "implements ...Constants" old-Java hack (to static imports).
> - Purged some unused imports.
> - A little documentation, editing, TODOs.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java
709a77f 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowSchemasHandler.java
ef3e1b0 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java
be53c84 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 9477a59

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaConstants.java
8350d89 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilterBuilder.java
ddbbe51 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java
77c6b9a 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaTable.java
66ba2e3 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/RecordGenerator.java
947998d 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java ec8ee2b

>   exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/SelectedTable.java
2c0a503 
>   exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java e2ac9ed

> 
> Diff: https://reviews.apache.org/r/33345/diff/
> 
> 
> Testing
> -------
> 
> Ran tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message