drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 33322: DRILL-2696: Part 1: Test for future DRILL-2696 PathScanner fix (currently disabled with @Ignore).
Date Tue, 21 Apr 2015 04:57:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33322/#review80908
-----------------------------------------------------------


Patch looks fine, but I would like to see the fix as well.

- Parth Chandra


On April 20, 2015, 3:03 a.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33322/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 3:03 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Bugs: DRILL-2696
>     https://issues.apache.org/jira/browse/DRILL-2696
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Unit test class/methods for PathScanner, with one method detecting DRILL-2696 problem
(currently disabled with @Ignore).
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/drill/common/util/PathScannerTest.java PRE-CREATION

>   common/src/test/resources/org/apache/drill/common/util/PathScannerTest_3%_special.dat
PRE-CREATION 
>   common/src/test/resources/org/apache/drill/common/util/PathScannerTest_plain_name.dat
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33322/diff/
> 
> 
> Testing
> -------
> 
> Tested the new test with @Ignore disabled (to confirm that test detects problem).
> Re-tested with @Ignore reinstated (to confirm doesn't break things currently).
> 
> Ran existing tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message