drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 33290: DRILL-2782: 1-Hygiene before: Decide, implement behavior for transaction-related JDBC methods
Date Mon, 20 Apr 2015 03:03:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33290/
-----------------------------------------------------------

(Updated April 20, 2015, 3:03 a.m.)


Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-2782
    https://issues.apache.org/jira/browse/DRILL-2782


Repository: drill-git


Description
-------

- Fixed/moved checkNotClosed to after constructor.
- Removed redundant "public"; "privatized" logger.
- Purged unused imports.
- A little commenting, editing, wrapping.


Diffs (updated)
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java a52644d 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 3fdbf84 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 78ca221 

Diff: https://reviews.apache.org/r/33290/diff/


Testing
-------

Ran existing tests; no new problems.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message