drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Re: Review Request 33322: DRILL-2696: Part 1: Test for future DRILL-2696 PathScanner fix (currently disabled with @Ignore).
Date Mon, 20 Apr 2015 03:03:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33322/
-----------------------------------------------------------

(Updated April 20, 2015, 3:03 a.m.)


Review request for drill, Mehant Baid and Parth Chandra.


Changes
-------

Just removed a space from Git commit comment.


Bugs: DRILL-2696
    https://issues.apache.org/jira/browse/DRILL-2696


Repository: drill-git


Description
-------

Unit test class/methods for PathScanner, with one method detecting DRILL-2696 problem (currently
disabled with @Ignore).


Diffs (updated)
-----

  common/src/test/java/org/apache/drill/common/util/PathScannerTest.java PRE-CREATION 
  common/src/test/resources/org/apache/drill/common/util/PathScannerTest_3%_special.dat PRE-CREATION

  common/src/test/resources/org/apache/drill/common/util/PathScannerTest_plain_name.dat PRE-CREATION


Diff: https://reviews.apache.org/r/33322/diff/


Testing
-------

Tested the new test with @Ignore disabled (to confirm that test detects problem).
Re-tested with @Ignore reinstated (to confirm doesn't break things currently).

Ran existing tests.


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message