drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 32404: DRILL-2514: Add support for impersonation in FileSystem storage plugin
Date Thu, 16 Apr 2015 20:52:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32404/
-----------------------------------------------------------

(Updated April 16, 2015, 8:51 p.m.)


Review request for drill and Jacques Nadeau.


Changes
-------

- rebased on latest master
- addressed review comments


Repository: drill-git


Description
-------

Please see JIRA DRILL-2514 for details.


Diffs (updated)
-----

  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java
6d18d12 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBasePushFilterIntoScan.java
2b419d4 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java
7a0a64b 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
c10b0ab 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSubScan.java
23d8c5a 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/HivePushPartitionFilterIntoScan.java
374c486 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java b96fda4

  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java
f4baf3b 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveSubScan.java
1233202 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java
0e16e6f 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java
b086786 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoPushDownFilterForScan.java
9af49b1 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoStoragePlugin.java
e46d8ec 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoSubScan.java
36008cf 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/schema/MongoSchemaFactory.java
3c70638 
  distribution/src/resources/drill-override-example.conf 943d644 
  exec/java-exec/pom.xml f5313ca 
  exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 7d89ac9 
  exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillFile.java f9a8ff5 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 8c402e8 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 2fa0b18 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/ViewExpansionContext.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java b1a71a5 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java defb4e4

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractFileGroupScan.java
ee809fc 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScan.java
8fe21e6 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractSubScan.java a36a46e

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperator.java a5518ca

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java e25f1c0

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillTable.java c8f872e

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillViewTable.java 68e666a

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DynamicDrillTable.java
843db58 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 7892999

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
a17a604 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/torel/ConversionContext.java
a486369 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
4471d4f 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractStoragePlugin.java b032fce

  exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaConfig.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaFactory.java feadabd 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePlugin.java ef5978c 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java 5d0eed6

  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java c5ca41b

  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
44132d0 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatPlugin.java 58d5b42 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
45e9129 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
6e1e0cc 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java 54cad56

  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasySubScan.java e78ba0b

  exec/java-exec/src/main/java/org/apache/drill/exec/store/direct/DirectGroupScan.java 262c6be

  exec/java-exec/src/main/java/org/apache/drill/exec/store/direct/DirectSubScan.java 89694f8

  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
bf46395 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaGroupScan.java
22cc483 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java
77c6b9a 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaSubScan.java
b9349b0 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/RecordGenerator.java 947998d

  exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockGroupScanPOP.java dc90a33

  exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java 51b2208

  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
e204a2c 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java acac61f

  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRowGroupScan.java
fd40f41 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
c1f815e 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java b92f98c

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTableScan.java f8baf97

  exec/java-exec/src/main/java/org/apache/drill/exec/util/ImpersonationUtil.java PRE-CREATION

  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 0df5145 
  exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java 58f4256

  exec/java-exec/src/main/resources/drill-module.conf 6bd8db0 
  exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 6df5801 
  exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java 264123f 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationMetadata.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java
PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java ba905c4

  pom.xml f6bcd91 

Diff: https://reviews.apache.org/r/32404/diff/


Testing
-------

Manually tested. Unittests with MiniDFS are coming in next patch.


Thanks,

Venki Korukanti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message