drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 33220: DRILL-2422: Before creating view make sure if a table with given name already exists.
Date Wed, 15 Apr 2015 18:00:36 GMT


> On April 15, 2015, 5:44 p.m., Jinfeng Ni wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java,
line 74
> > <https://reviews.apache.org/r/33220/diff/2/?file=930391#file930391line74>
> >
> >     What is ValidationException? For "table not exists" type error, Calcite/Optiq
will throw SqlValidatorException? Does it make sense to raise SqlValidatorException for "table
with same name already exists" error?

Optiq/Calcite ultimately throws the ValidationException. I thought about using SqlValidationException,
but it takes another exception cause. It doesn't have a constructor which just takes a error
message.


- Venki


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33220/#review80220
-----------------------------------------------------------


On April 15, 2015, 3:01 p.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33220/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 3:01 p.m.)
> 
> 
> Review request for drill and Jinfeng Ni.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> See DRILL-2422 for details.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
300d65d 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
4347249 
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
325f770 
>   exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 578eace

> 
> Diff: https://reviews.apache.org/r/33220/diff/
> 
> 
> Testing
> -------
> 
> Added unittests for both CreateTable and CreateView
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message