drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti" <venki.koruka...@gmail.com>
Subject Re: Review Request 33209: DRILL-2341: Type information is lost if list of fields is specified during create view
Date Wed, 15 Apr 2015 14:51:38 GMT


> On April 15, 2015, 6:11 a.m., Jinfeng Ni wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java,
line 114
> > <https://reviews.apache.org/r/33209/diff/1/?file=929615#file929615line114>
> >
> >     One question. Seems you call DrillRelOptUtil.createRename(), just to get the
rowtype of this new project. Why can't you create a rowType with the desired field name directly?

Let me if this still makes sense after the refactoring.


- Venki


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33209/#review80165
-----------------------------------------------------------


On April 15, 2015, 2:50 p.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33209/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 2:50 p.m.)
> 
> 
> Review request for drill and Jinfeng Ni.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Create a cast to rename the view definition query row type to view field list specified
in CREATE VIEW statement.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
cacf26b 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
300d65d 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
4347249 
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
325f770 
>   exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 578eace

> 
> Diff: https://reviews.apache.org/r/33209/diff/
> 
> 
> Testing
> -------
> 
> Includes unittests.
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message