drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni" <...@maprtech.com>
Subject Re: Review Request 33209: DRILL-2341: Type information is lost if list of fields is specified during create view
Date Wed, 15 Apr 2015 05:45:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33209/#review80159
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
<https://reviews.apache.org/r/33209/#comment129925>

    This part of logic is quite similar in ViewHandler and CreateTableHandler. Is it possible
that we move the common code to a helper method (check the field count, *, create the rename
project, etc), so that both of the Handlers could call this method?


- Jinfeng Ni


On April 14, 2015, 10:28 p.m., Venki Korukanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33209/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 10:28 p.m.)
> 
> 
> Review request for drill and Jinfeng Ni.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Create a cast to rename the view definition query row type to view field list specified
in CREATE VIEW statement.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
cacf26b 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
4347249 
>   exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 578eace

> 
> Diff: https://reviews.apache.org/r/33209/diff/
> 
> 
> Testing
> -------
> 
> Includes unittests.
> 
> 
> Thanks,
> 
> Venki Korukanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message