drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes" <hanifigu...@gmail.com>
Subject Re: Review Request 33052: DRILL-2611: value vectors should report valid value count
Date Mon, 13 Apr 2015 23:01:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33052/
-----------------------------------------------------------

(Updated April 13, 2015, 11:01 p.m.)


Review request for drill, Mehant Baid and Parth Chandra.


Repository: drill-git


Description
-------

DRILL-2611: value vectors should report valid value count

Changes
- unify the behavior of value count interfaces across VVs -- get/setters
- ensure value count reported reflects underlying state of the buffer
- enforce consumers to use getAccessor().get/setValueCount
- ensure metadata created based on getAccessor().getValueCount


Diffs (updated)
-----

  exec/java-exec/src/main/codegen/templates/ComplexWriters.java 576fd8352197ba950be7d7e661fb52dd92b52f2a

  exec/java-exec/src/main/codegen/templates/FixedValueVectors.java e9ec220dc653db1e1acb0538bbbc1207fb4ee194

  exec/java-exec/src/main/codegen/templates/NullableValueVectors.java 075316e4f3ac5327e7893688c5e88cfee98e50bc

  exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java c7cf8e6fe18f1b9813ae22495ac79a447f61cfff

  exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java edb851eb10be43d889ce5fd98d9bde036707870a

  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReader.java
759327a307aefd51dc69ea4282a7d58d6309e142 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedByteAlignedReader.java
c2af964fd606924587fe2093b3ccb1ec1de922af 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedWidthRepeatedReader.java
f20d7655c76237fc5d3a95760f00ca2400a8df07 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java
16519a851a18924fb59753c456a2da4076d5d245 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java
8087118e1de8ef1b043c80ab4fc85215284670dc 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLengthColumnReaders.java
7464f30179059a728f5c30f37c17adf0f332604c 
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseDataValueVector.java d48ea99237bb822cafc8b835c3af0f4789c6eb29

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java 81d3a8623fb86068d8c81f08e1d38d37b856e26c

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java d8bd9723db9f2ecd1466b1144345ca371f68a3bb


Diff: https://reviews.apache.org/r/33052/diff/


Testing
-------

unit, reg, sf100


Thanks,

Hanifi Gunes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message