drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse" <altekruseja...@gmail.com>
Subject Re: Review Request 33139: Drill-1827: Unit test framework reports expected and actual values backwards in unordered comparison
Date Mon, 13 Apr 2015 19:06:12 GMT


> On April 13, 2015, 6:57 p.m., Venki Korukanti wrote:
> > exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java, line 295
> > <https://reviews.apache.org/r/33139/diff/1/?file=926154#file926154line295>
> >
> >     From the signature of compareResults, it is expecting "expected" results in
first argument. Looks like we need to keep the same order (expected, actual) as before when
calling compareResults.

Well that was really stupid, a great reason not to use IDE name refactoring blindly to fix
such a problem, new patch shortly.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33139/#review79917
-----------------------------------------------------------


On April 13, 2015, 6:41 p.m., Jason Altekruse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33139/
> -----------------------------------------------------------
> 
> (Updated April 13, 2015, 6:41 p.m.)
> 
> 
> Review request for drill and Venki Korukanti.
> 
> 
> Bugs: DRILL-1827
>     https://issues.apache.org/jira/browse/DRILL-1827
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> There was a bug in the unit test framework that was flipping the expected and actual
result sets. I added a try/finally block as well to make sure we cleanup the resources from
the queries even if the result set verification fails.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java d05c896 
> 
> Diff: https://reviews.apache.org/r/33139/diff/
> 
> 
> Testing
> -------
> 
> Uint test framework changes only, unit tests are passing.
> 
> 
> Thanks,
> 
> Jason Altekruse
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message