drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni" <...@maprtech.com>
Subject Review Request 33136: Rebase Drill's forked Optiq library onto Calcite release 1.0.
Date Mon, 13 Apr 2015 17:47:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33136/
-----------------------------------------------------------

Review request for drill.


Repository: drill-git


Description
-------

Drill currently uses a forked Optiq (Renamed to Calcite) version, dated back in July 2014.
The forked version has 10-20 Drill specific patches. However, we did not rebase the forked
version onto the on-going Calcite release. As such, Drill misses some bug fixes/new feature
development on Calcite side.

This patch is trying to rebase the Drill's forked version onto Calcite release 1.0. (More
precisely, on commit of CALCITE-603, when this rebasing work started).

Most of changes happen due to Calcite's package structure / renaming (See CALCITE-296]. 

Some Drill specific changes:

1. Provide a Drill specifc RelDataTypeSystem, to support decimal with precision/scale up to
38.
2. Modify Drill's parser, to allow * in Compound Identifier.
3. Provide Drill specific FilterJoinRule, to enforce Drill only support equal-join in JOIN
operator.
4. Modify Drill costing comparison, such that the costing oder is a total order when compare
different plans.
5. Modify costing estimation for Drill Project operator. 
6. Use a ProjectRemove rule, such that it will honor parent's output field name.
7. Modify Calcite's Frameworks/planner interface, such that Drill will use validatedRowType
to construct a top-level project, to ensure the final output field is what the query specified.
(Calcite could inject "$F0", or "$EXPR0 into converted RelNode tree, in Sql2RelConverter)
8. Fix couple of Drill unit test cases, since the expected result by query semantics are not
fixed.
9. Some type-related to Drill Sql operators. 

Some impact of such rebasing.
1. TPCH Q16, or query with NOT IN predicate involving NULLABLE column could hit CanNotPlanException.


The previous plan for Q16, although return the correct result, is not valid, when the column
is nullable. See DRILL-1957 OR CALCITE-373.

2. Plan changed in some TPCH queries, which may cause timeout for Q5 in TPCH scale factor
100 run.
We probably need continue refine the costing estimation formula, especially for Join operator.


Diffs
-----

  common/pom.xml 525b533 
  common/src/main/java/org/apache/drill/common/logical/data/Join.java a3d44f5 
  common/src/main/java/org/apache/drill/common/logical/data/Order.java ee6f9a9 
  common/src/test/java/org/apache/drill/common/logical/data/OrderTest.java 144b35b 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/DrillHBaseTable.java
ff6991f 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBasePushFilterIntoScan.java
2b419d4 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java
7a0a64b 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
c10b0ab 
  contrib/storage-hive/core/pom.xml 9bd6293 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HiveUDFOperator.java
8a54bfe 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/HivePushPartitionFilterIntoScan.java
374c486 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveReadEntry.java
e964128 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java
f4baf3b 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveTable.java
a843146 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveViewTable.java
52ceccc 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
1d2902b 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java
0e16e6f 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoPushDownFilterForScan.java
9af49b1 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoStoragePlugin.java
e46d8ec 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/schema/MongoDatabaseSchema.java
5e63d81 
  contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/schema/MongoSchemaFactory.java
a227c9a 
  exec/java-exec/pom.xml fdd24ef 
  exec/java-exec/src/main/codegen/data/Parser.tdd 5485079 
  exec/java-exec/src/main/codegen/includes/compoundIdentifier.ftl 50d8c20 
  exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/View.java c5c62d8 
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java 8a5af56

  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionGenerationHelper.java
19cd1d8 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java da2229c 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 2fa0b18 
  exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java b1a71a5 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java f9cae48

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MergeJoinPOP.java 19f9b08

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/NestedLoopJoinPOP.java
8fcade6 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java a73bdad

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
bbd83c0 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbe.java
42c7010 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
dcf73b4 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java 5fb2585

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinTemplate.java
6da10d2 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java 7fa79a1

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
8fce52e 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinCreator.java
d6b566c 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
e230fd2 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java
42b1080 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortBatch.java 6f19e91

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
a23780e 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/StarColumnHelper.java d288479

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillAggregateRelBase.java
c733f77 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillFilterRelBase.java
7813d15 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillJoinRelBase.java
3b3aa1a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLimitRelBase.java
11164fb 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillProjectRelBase.java
7cf98cd 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelNode.java fd04cdd

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java cacf26b

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillScanRelBase.java
33581a3 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillScreenRelBase.java
9b31fb0 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStoreRelBase.java
adf7d6b 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillUnionRelBase.java
11ed8ba 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillWindowRelBase.java
fcf52ee 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillWriterRelBase.java
7ea98a4 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillCostBase.java 87a1ea3

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelOptCost.java 73c6c72

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelOptCostFactory.java
fc20d60 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DirPathBuilder.java cb38da9

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillAggregateRel.java
ee035c6 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillAggregateRule.java
66fc563 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java
310ef82 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java
0fe5a1a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillFilterJoinRules.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillFilterRel.java 63bef44

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillFilterRule.java
cb47adb 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillImplementor.java
7fff6e9 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillJoinRel.java 8d3e1bf

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillJoinRule.java cf15411

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillLimitRel.java 75a38d8

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillLimitRule.java f6c910e

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillMergeFilterRule.java
b406cfb 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillMergeProjectRule.java
b97d83e 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java 5dd6ed5

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectRel.java
14ea894 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectRule.java
7cef038 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushFilterPastProjectRule.java
e2310f7 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushPartitionFilterIntoScan.java
c6dceda 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjIntoScan.java
fcfced2 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastFilterRule.java
29e6559 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastJoinRule.java
7296d08 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
9832406 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceExpressionsRule.java
29175e5 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRel.java 7ed7885

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 92a804e

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java ab3d61b

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRule.java d71019a

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScreenRel.java 28f4205

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillSortRel.java 830f5f2

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillSortRule.java f968dbb

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillStoreRel.java 6295eab

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillTable.java c8f872e

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 39d5d4d

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRule.java f71d203

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillValuesRel.java a3551e7

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillValuesRule.java
d783f44 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillViewTable.java 68e666a

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRel.java 113f98c

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java
847e87a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWriterRel.java 04dd133

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DynamicDrillTable.java
843db58 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/EnumerableDrillRule.java
131c60f 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PartitionPruningUtil.java
88b4a51 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java
60aa1da 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/RelOptHelper.java 172ee2a

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
5cf360a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
5fab35a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AggPrelBase.java a69188b

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AggPruleBase.java e6c815b

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/BroadcastExchangePrel.java
0467a07 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ComplexToJsonPrel.java
bec3704 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
d794805 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DrillDistributionTrait.java
c45ae17 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DrillDistributionTraitDef.java
ae079a3 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ExchangePrel.java 5a75adb

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java 6198d37

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrule.java c15c5e0

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FlattenPrel.java 18a2cc2

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashAggPrel.java 0b9dcb6

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashAggPrule.java 1a43df5

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashJoinPrel.java f63057f

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashJoinPrule.java e802a40

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashToMergeExchangePrel.java
7920187 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashToRandomExchangePrel.java
6826e46 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/JoinPrel.java bfecd06

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/JoinPruleBase.java 77c055c

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitPrel.java 6012a5a

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitPrule.java 94685c1

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/MergeJoinPrel.java de5c2d5

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/MergeJoinPrule.java
5283467 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/OrderedPartitionExchangePrel.java
7bb4822 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
8737e68 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/Prel.java 7c63e6a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PrelUtil.java 44afd68

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProducerConsumerPrel.java
a9edd0c 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectAllowDupPrel.java
26bb9f6 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrel.java 310e18c

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrule.java b1d5a4c

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/Prule.java c0d6516 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PushLimitToTopN.java
6d318ea 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrel.java e65c110

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrule.java 1d915b7

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScreenPrel.java 4356515

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScreenPrule.java 9cb8e15

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SelectionVectorRemoverPrel.java
aea5192 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SingleMergeExchangePrel.java
8264509 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SinglePrel.java 914ee04

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SortConvertPrule.java
a9955a3 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SortPrel.java 8156843

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SortPrule.java 2ebd015

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/StreamAggPrel.java e8a70f2

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/StreamAggPrule.java
929cb6d 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SubsetTransformer.java
72e06d9 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/TopNPrel.java ac1811b

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnionAllPrel.java d5698f7

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnionAllPrule.java fa533f7

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnionDistinctPrel.java
05086ed 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnionDistinctPrule.java
fd85448 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnionExchangePrel.java
c35328b 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnionPrel.java 6303489

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnorderedDeMuxExchangePrel.java
79253c7 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/UnorderedMuxExchangePrel.java
8ab05a0 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java f23a073

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java 796c654

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WriterPrel.java dc3d6df

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WriterPrule.java 6bd89b0

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/explain/NumberingRelWriter.java
387a442 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/explain/PrelSequencer.java
cb6d656 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/ComplexToJsonPrelVisitor.java
37b2f8b 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/ExcessiveExchangeIdentifier.java
9d74802 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java
375d69f 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java
ccf890d 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/JoinPrelRenameVisitor.java
fa750c2 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/MemoryEstimationVisitor.java
0fd1dd0 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/ProducerConsumerPrelVisitor.java
2cbf790 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/RelUniqifier.java
6ef9776 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/RewriteProjectToFlatten.java
bedc7bc 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/RexVisitorComplexExprSplitter.java
9742a90 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/SelectionVectorPrelVisitor.java
4e4d6c1 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/SplitUpComplexExpressions.java
9e01c42 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/StarColumnConverter.java
9f4924e 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/SwapHashJoinVisitor.java
18d5e60 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Checker.java a22da17 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConvertletTable.java
7c89897 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillExtractConvertlet.java
31aa364 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java 97d873c

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlAggOperator.java
7ab2e9f 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java 7bd48c8

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java b98778d

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicReturnType.java 1fe1d27

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicType.java 7255dae

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/FixedRange.java 91a7c65 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/AbstractSqlHandler.java
56c2a42 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
300d65d 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
5ee502d 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java
709a77f 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ExplainHandler.java
1cce6a5 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SetOptionHandler.java
dc63ef9 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java
2504ed9 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowSchemasHandler.java
ef3e1b0 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java
be53c84 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java
132a2c9 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/UseSchemaHandler.java
f99aea3 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
4347249 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
eb97941 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillCompoundIdentifier.java
d5fa215 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillParserUtil.java
cba5a18 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java
3e8d4f1 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java
ae1c744 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java
b7352b4 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeTable.java
7d464e1 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java a0d6f7b

  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowFiles.java
38abfeb 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowSchemas.java
9d8771a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowTables.java
da3f0fd 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlUseSchema.java
c8af002 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
4830fe1 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/impl/DrillParserWithCompoundIdConverter.java
be333c0 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/torel/ConversionContext.java
a486369 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/DrillFixedRelDataTypeImpl.java
d88f883 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/DrillRelDataTypeSystem.java
PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/RelDataTypeDrillImpl.java
559cf68 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/RelDataTypeHolder.java
1485aa3 
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 19d77b0 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
45d393c 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionManager.java 4ffe9a3

  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValidator.java 43071e7

  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
1a8559e 
  exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java b9721cc

  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 9477a59 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/PartitionExplorerImpl.java 024ca09

  exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java 889db12 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaFactory.java feadabd 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginOptimizerRule.java
32ec6ff 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java 5d0eed6

  exec/java-exec/src/main/java/org/apache/drill/exec/store/SubSchemaWrapper.java c792550 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java c5ca41b

  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
44132d0 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
45e9129 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaDrillTable.java
ab94727 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaPushFilterIntoRecordGenerator.java
61cc47b 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java
77c6b9a 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaTable.java 66ba2e3

  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/RecordGenerator.java 947998d

  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java ec8ee2b 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/SelectedTable.java 2c0a503

  exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java 51b2208

  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java acac61f

  exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java 2acb727

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryRecord.java 9cb001d 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/StaticDrillTable.java d9374cb

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java 2c338ca 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java 13e0ff6

  exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ThreadsRecord.java b184880

  exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/UnsupportedDataTypeException.java
305e6d3 
  exec/java-exec/src/test/java/org/apache/drill/PlanTestBase.java 4744978 
  exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java 264123f 
  exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java ec1fb58 
  exec/java-exec/src/test/java/org/apache/drill/TestProjectPushDown.java 34e57b3 
  exec/java-exec/src/test/java/org/apache/drill/TestStarQueries.java effef9b 
  exec/java-exec/src/test/java/org/apache/drill/TestTpchDistributed.java b062b39 
  exec/java-exec/src/test/java/org/apache/drill/TestTpchDistributedStreaming.java 4a8d7c9

  exec/java-exec/src/test/java/org/apache/drill/TestTpchExplain.java 1d67a3a 
  exec/java-exec/src/test/java/org/apache/drill/TestTpchPlanning.java 79faf2b 
  exec/java-exec/src/test/java/org/apache/drill/TestTpchSingleMode.java 0098eb8 
  exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 11d83f9 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestJoinComplex.java
cdda10e 
  exec/java-exec/src/test/java/org/apache/drill/exec/planner/logical/FilterSplitTest.java
7c85c19 
  exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestSqlBracketlessSyntax.java a5bcdec

  exec/java-exec/src/test/java/org/apache/drill/exec/test/Drill2130JavaExecHamcrestConfigurationTest.java
03d858c 
  exec/jdbc-all/pom.xml b369aed 
  exec/jdbc/pom.xml b4ec758 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java 4979dff 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcDataTest.java 0e9f8a0 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 09ad5db 
  pom.xml e13cc5d 

Diff: https://reviews.apache.org/r/33136/diff/


Testing
-------

Unit testcase clean run. (except for disabled testcases. See DRILL-2630, DRILL-2761, etc)


Thanks,

Jinfeng Ni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message