drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parth Chandra" <pchan...@maprtech.com>
Subject Re: Review Request 33044: DRILL-2613: 2-Core: Impl. ResultSet.getXxx(...) number-to-number data conversions.
Date Fri, 10 Apr 2015 21:11:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33044/#review79736
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java
<https://reviews.apache.org/r/33044/#comment129271>

    Did you mean to remove the space between new and InvalidAccessException?



exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
<https://reviews.apache.org/r/33044/#comment129272>

    Can we remove all these commented out methods?



exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java
<https://reviews.apache.org/r/33044/#comment129282>

    call getIntValueorThrow instead?


- Parth Chandra


On April 10, 2015, 1:32 a.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33044/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 1:32 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Bugs: DRILL-2613
>     https://issues.apache.org/jira/browse/DRILL-2613
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - Created tests:
>   - integration-level unit test ResultSetGetMethodConversionsTest
>   - unit-level unit test TypeConvertingAccessorSqlTest
> - Created number-converting TypeConvertingSqlAccessor.
> - Created conversion exceptions (SQLConversionException, SQLConversionOverflowException).
> - Adjusted things:
>   - Moved InvalidAccessException out into its own file, refined ancestry.
>   - Moved getType() up to SqlAccessor (for access by TypeConvertingSqlAccessor).
>   - Made AbstractSqlAccessor public (for use by TypeConvertingSqlAccessor).
> - Documented supported ResultSet.getXxx(...) conversions (on new interface
>   DrillResultSet).
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/codegen/templates/SqlAccessors.java c0ece9b 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java
1605c7d 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java
c8d6cc7 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java
adee171 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/InvalidAccessException.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java
6007bf4 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java ccf2658 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc 
>   exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionException.java PRE-CREATION

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionOverflowException.java PRE-CREATION

>   exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java PRE-CREATION

>   exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java
PRE-CREATION 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33044/diff/
> 
> 
> Testing
> -------
> 
> Ran new specific tests.
> 
> Ran existing tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message